[systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

[Karel Zak]

On Sat, Feb 16, 2013 at 05:40:18PM +0100, Kay Sievers wrote:
> On Sat, Feb 16, 2013 at 4:45 PM, Zbigniew Jędrzejewski-Szmek
> <zbyszek at in.waw.pl> wrote:
> > On Wed, Feb 13, 2013 at 05:39:54AM +0200, Zeeshan Ali (Khattak) wrote:
> 
> >> +        } else if (streq(name, "SYSTEM_ID"))
> >> +                udev_builtin_add_property(dev, test, "ID_FS_SYSTEM_ID", value);
> >> +
> >> +        else if (streq(name, "PUBLISHER_ID"))
> >> +                udev_builtin_add_property(dev, test, "ID_FS_PUBLISHER_ID", value);
> >> +
> >> +        else if (streq(name, "APPLICATION_ID"))
> >> +                udev_builtin_add_property(dev, test, "ID_FS_APPLICATION_ID", value);
> >> +
> >> +        else if (streq(name, "BOOT_SYSTEM_ID"))
> >> +                udev_builtin_add_property(dev, test, "ID_FS_BOOT_SYSTEM_ID", value);
> 
> > iiuc, those strings are under the control of the FS creator.
> > Shouldn't they be treated like e.g. LABEL and passed through
> > blkid_safe_string and blkid_encode_string?
> 
> Yeah, they need to. I can do that when I merge it.
> 
> I still need to check with Karel first, because I think that doesn't
> look like something we should export for iso9660 from libblkid:
>    ID_FS_UUID=2012-05-22-20-55-32-00
> 

 commit 05a9d5120c10ffc21f21db09eec685a7258b2fb4
 Author: Andreas Vogel <Andreas.Vogel at anvo-it.de>
 Date:   Wed Mar 21 13:43:35 2012 +0100

     libblkid: generate pseudo-UUID for ISO9660 image file
         
     The UUID is generated from the modification date in the ISO volume
     descriptor. As GRUB 2 is using this definition for the pseudo UUID for
     ISO9660 files libblkid would be perfectly compatible with GRUB 2.


> It would not cause much trouble, but it really is no UUID in any usual
> sense, and probably not very useful to export as a symlink in /dev.

 I guess it's relatively safe to use this pseudo UUID. And
 it is not the first ugly UUID (see FAT) or HFS (UUID based on md5).
 
    Karel

-- 
 Karel Zak  <kzak at redhat.com>
 http://karelzak.blogspot.com