[systemd-devel] [PATCH 2/2] journal, readahead: remove file handle leaks

[Zbigniew Jędrzejewski-Szmek]

On Sun, Jan 27, 2013 at 10:42:45PM +0000, Sami Kerola wrote:
> On Sun, Jan 27, 2013 at 10:17 PM, David Strauss <david at davidstrauss.net> wrote:
> > Does the leak show up under Valgrind with fd checking enabled?
> 
> I did not check.
> 
> > On Sun, Jan 27, 2013 at 1:58 PM, Kay Sievers <kay at vrfy.org> wrote:
> >> On Sun, Jan 27, 2013 at 10:51 PM, Sami Kerola <kerolasa at iki.fi> wrote:
> >>> Found with the coccicheck-0.2.4 open file check.
> >>
> >> I didn't check the whole list, but where I looked, the check is just
> >> not smart enough to understand:
> >>   _cleanup_fclose_ FILE *f = NULL;
> >>
> >> which causes the cleanup automatically to be added by the compiler and
> >> not by explicit code. It's used that way in many places in the systemd
> >> code.
> 
> Bizarre. The two files I sent fixes about where the only occurrence
> coccicheck complained. If the same technique is used elsewhere in
> files the check failed to notice thous 'leaks'.
> 
> Kay, thanks for review, the patch 0002 must dropped.
Didn't check the whole patch, but seems that 0001 should be replaced
with additions of _cleanup_closedir_ and such.

Zbyszek