[systemd-devel] [PATCH] bash-completion: split completions and move to new location

[Michael Biebl]

2013/3/3 Michael Biebl <mbiebl at gmail.com>:
> 2013/3/3 Kay Sievers <kay at vrfy.org>:
>> On Sat, Mar 2, 2013 at 10:46 PM, Michael Biebl <mbiebl at gmail.com> wrote:
>>> That said, I can prep a follow-up patch, which makes that configurable
>>> and uses "pkg-config --variable=completionsdir bash-completion".
>>> Pretty much
>>> what we do for --with-dbus*dir.
>>>
>>> Let me know if you also want the latter bits.
>>
>> Sounds good to me.
>
> Ok, will have a look then. Should be mostly C&P from what is already
> in configure.ac.


See attached patches.
First one replaced pkg-config with $PKG_CONFIG (which we also
recommend in man 7 daemon).
The second makes bashcompletiondir configurable via
--with-bashcompletiondir=DIR.

If not specified, it will try $PKG_CONFIG --variable=completionsdir
bash-completion.
Since we don't want a hard build dependency on bash-completion, it
will fall-back to ${datadir}/bash-completion/completions if
bash-completion.pc is not installed.

Ok to commit?

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-sys-use-PKG_CONFIG-instead-of-calling-the-pkg-.patch
Type: application/octet-stream
Size: 1996 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130304/fb11b88c/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-build-sys-don-t-hard-code-bash-completion-directory.patch
Type: application/octet-stream
Size: 2996 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130304/fb11b88c/attachment-0001.obj>