[systemd-devel] [PATCH] bash-completion: split completions and move to new location

[Kay Sievers]

On Mon, Mar 4, 2013 at 12:18 AM, Michael Biebl <mbiebl at gmail.com> wrote:
> 2013/3/3 Michael Biebl <mbiebl at gmail.com>:
>> 2013/3/3 Kay Sievers <kay at vrfy.org>:
>>> On Sat, Mar 2, 2013 at 10:46 PM, Michael Biebl <mbiebl at gmail.com> wrote:
>>>> That said, I can prep a follow-up patch, which makes that configurable
>>>> and uses "pkg-config --variable=completionsdir bash-completion".
>>>> Pretty much
>>>> what we do for --with-dbus*dir.
>>>>
>>>> Let me know if you also want the latter bits.
>>>
>>> Sounds good to me.
>>
>> Ok, will have a look then. Should be mostly C&P from what is already
>> in configure.ac.
>
>
> See attached patches.
> First one replaced pkg-config with $PKG_CONFIG (which we also
> recommend in man 7 daemon).
> The second makes bashcompletiondir configurable via
> --with-bashcompletiondir=DIR.
>
> If not specified, it will try $PKG_CONFIG --variable=completionsdir
> bash-completion.
> Since we don't want a hard build dependency on bash-completion, it
> will fall-back to ${datadir}/bash-completion/completions if
> bash-completion.pc is not installed.
>
> Ok to commit?

Sure. Works fine here.

Thanks,
Kay