[systemd-devel] [PATCH 1/2] systemd-analyze: refactor for more data collection

Kok, Auke-jan H auke-jan.h.kok at intel.com
Mon Mar 25 13:32:14 PDT 2013


On Sun, Mar 24, 2013 at 11:23 AM, Umut Tezduyar <umut at tezduyar.com> wrote:
> ---
>  src/analyze/systemd-analyze.c |  119 +++++++++++++++++++++++------------------
>  1 files changed, 66 insertions(+), 53 deletions(-)
>
> diff --git a/src/analyze/systemd-analyze.c b/src/analyze/systemd-analyze.c
> index 01bf55e..3dcde30 100644
> --- a/src/analyze/systemd-analyze.c
> +++ b/src/analyze/systemd-analyze.c
> @@ -70,7 +70,7 @@ struct boot_times {
>          usec_t userspace_time;
>          usec_t finish_time;
>  };
> -struct unit_times {
> +struct unit_stat {
>          char *name;
>          usec_t ixt;
>          usec_t iet;

hey,

almost half of this patch is about just renaming this struct... is
there a reason to do this at all? it seems like the old name is
actually better at describing the content.

Auke


More information about the systemd-devel mailing list