[systemd-devel] [PATCH 1/2] systemd-analyze: refactor for more data collection

Umut Tezduyar umut at tezduyar.com
Tue Mar 26 04:01:14 PDT 2013


Hi,

Reason was for patch 2/2 as this is patch 1/2. Thanks.


On Mon, Mar 25, 2013 at 9:32 PM, Kok, Auke-jan H
<auke-jan.h.kok at intel.com>wrote:

> On Sun, Mar 24, 2013 at 11:23 AM, Umut Tezduyar <umut at tezduyar.com> wrote:
> > ---
> >  src/analyze/systemd-analyze.c |  119
> +++++++++++++++++++++++------------------
> >  1 files changed, 66 insertions(+), 53 deletions(-)
> >
> > diff --git a/src/analyze/systemd-analyze.c
> b/src/analyze/systemd-analyze.c
> > index 01bf55e..3dcde30 100644
> > --- a/src/analyze/systemd-analyze.c
> > +++ b/src/analyze/systemd-analyze.c
> > @@ -70,7 +70,7 @@ struct boot_times {
> >          usec_t userspace_time;
> >          usec_t finish_time;
> >  };
> > -struct unit_times {
> > +struct unit_stat {
> >          char *name;
> >          usec_t ixt;
> >          usec_t iet;
>
> hey,
>
> almost half of this patch is about just renaming this struct... is
> there a reason to do this at all? it seems like the old name is
> actually better at describing the content.
>
> Auke
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130326/f5b67723/attachment.html>


More information about the systemd-devel mailing list