[systemd-devel] [PATCH 17/28] dhcp: Support seconds elapsed since start of DHCP negotiation

Lennart Poettering lennart at poettering.net
Wed Nov 13 16:23:54 PST 2013


On Wed, 13.11.13 23:22, Patrik Flykt (patrik.flykt at linux.intel.com) wrote:

> It was noticed by Grant Erickson in ConnMan commit
> 95e15c09350acf58d4707056ae2614570883ef66 that:
> 
>    "Certain DHCP servers, such as that implemented in Mac OS X
>     (< 10.7) for its "Internet Sharing" feature, refuse to issue
>     a DHCP lease to clients that have not set a non-zero value
>     in their DISCOVER or REQUEST packets."

I am quite sure it would be better to add this comment to the sources
too, there are easier to find there, and people will less likely drop
the assignment when they revisit the code.

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list