[systemd-devel] [PATCH 17/28] dhcp: Support seconds elapsed since start of DHCP negotiation

[Patrik Flykt]

On Thu, 2013-11-14 at 01:23 +0100, Lennart Poettering wrote:
> 
> > It was noticed by Grant Erickson in ConnMan commit
> > 95e15c09350acf58d4707056ae2614570883ef66 that:
> > 
> >    "Certain DHCP servers, such as that implemented in Mac OS X
> >     (< 10.7) for its "Internet Sharing" feature, refuse to issue
> >     a DHCP lease to clients that have not set a non-zero value
> >     in their DISCOVER or REQUEST packets."
> 
> I am quite sure it would be better to add this comment to the sources
> too, there are easier to find there, and people will less likely drop
> the assignment when they revisit the code. 

RFC 2131 is a bit vague but indicates 'secs' field is a SHOULD for a
client. With that in mind I'd hope people would read the commit message
before removing code from a protocol, but I'll add a comment to make it
clear.

Cheers,

	Patrik