[systemd-devel] [systemd-commits] units/user at .service.in

[Zbigniew Jędrzejewski-Szmek]

On Mon, Sep 30, 2013 at 07:17:54PM -0700, Lennart Poettering wrote:
>     units: Add SHELL environment variable
...
> diff --git a/units/user at .service.in b/units/user at .service.in
> index 3f8b59d..3718a57 100644
> --- a/units/user at .service.in
> +++ b/units/user at .service.in
> @@ -13,6 +13,7 @@ After=systemd-user-sessions.service
>  User=%I
>  PAMName=systemd-user
>  Type=notify
> +Environment=SHELL=%s
>  ExecStart=- at rootlibexecdir@/systemd --user
>  Environment=DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/%I/dbus/user_bus_socket
>  Slice=user-%i.slice

Hm, shouldn't we treat $SHELL like $HOME and $USER, and set it "for
the units which have User= set, which includes user systemd instances"
(quoting systemd.exec(5) here)? This would be more consistent.

Zbyszek