[systemd-devel] Some thoughts about loop_read/loop_write in util.c

[cee1]

2013/9/12 Lennart Poettering <lennart at poettering.net>:
> On Thu, 12.09.13 09:43, cee1 (fykcee1 at gmail.com) wrote:
>
>> What about the following patch? It simply do read/write again if poll
>> returns, and let read/write report error if something is wrong.
>
> I guess that patch makes sense, but could you change it to not just
> comment but delete the old lines? Also, could you add a comment there:
>
> /* We knowingly ignore the revents value here, and expect that any
>    error/EOF is reported via read()/write() */
OK, see the attachment.


-- 
Regards,

- cee1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-util.c-ignore-pollfd.revent-for-loop_read-loop_write.patch
Type: application/octet-stream
Size: 1790 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130913/ed688248/attachment.obj>