[systemd-devel] Some thoughts about loop_read/loop_write in util.c

[Lennart Poettering]

On Fri, 13.09.13 08:38, cee1 (fykcee1 at gmail.com) wrote:

> 2013/9/12 Lennart Poettering <lennart at poettering.net>:
> > On Thu, 12.09.13 09:43, cee1 (fykcee1 at gmail.com) wrote:
> >
> >> What about the following patch? It simply do read/write again if poll
> >> returns, and let read/write report error if something is wrong.
> >
> > I guess that patch makes sense, but could you change it to not just
> > comment but delete the old lines? Also, could you add a comment there:
> >
> > /* We knowingly ignore the revents value here, and expect that any
> >    error/EOF is reported via read()/write() */
> OK, see the attachment.

Ah! No need to resend after all, found your original mail. Applied! Thanks!



Lennart

-- 
Lennart Poettering - Red Hat, Inc.