[systemd-devel] [PATCH] sd-dhcp-client: log positive error number

[Tom Gundersen]

Applied. Thanks!

On Sun, Apr 27, 2014 at 10:01 PM, Umut Tezduyar Lindskog
<umut.tezduyar at axis.com> wrote:
> Log error no for such client_stop(client, DHCP_EVENT_STOP)
> ---
>  src/libsystemd-network/sd-dhcp-client.c |   16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c
> index 854c671..f2266e0 100644
> --- a/src/libsystemd-network/sd-dhcp-client.c
> +++ b/src/libsystemd-network/sd-dhcp-client.c
> @@ -231,7 +231,21 @@ static int client_initialize(sd_dhcp_client *client) {
>  static sd_dhcp_client *client_stop(sd_dhcp_client *client, int error) {
>          assert_return(client, NULL);
>
> -        log_dhcp_client(client, "STOPPED: %s", strerror(-error));
> +        if (error < 0)
> +                log_dhcp_client(client, "STOPPED: %s", strerror(-error));
> +        else {
> +                switch(error) {
> +                case DHCP_EVENT_STOP:
> +                        log_dhcp_client(client, "STOPPED: Requested by user");
> +                        break;
> +                case DHCP_EVENT_NO_LEASE:
> +                        log_dhcp_client(client, "STOPPED: No lease");
> +                        break;
> +                default:
> +                        log_dhcp_client(client, "STOPPED: Unknown reason");
> +                        break;
> +                }
> +        }
>
>          client = client_notify(client, error);
>
> --
> 1.7.10.4
>
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel