[systemd-devel] [PATCH 2/2 v3] socket: introduce SELinuxContextFromNet option

[Lennart Poettering]

On Wed, 27.08.14 04:45, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> > +        }
> > +
> > +        bcon = context_new(mycon);
> > +        if (!bcon)
> > +                goto out;
> This will return 0. Should return log_oom() or ENOMEM instead?

Please use ENOMEM here, don't use log_oom(). This is is more or less a
library call, so it shouldn't log on its own, but leave that to the caller...

Lennart

-- 
Lennart Poettering, Red Hat