[systemd-devel] [PATCH 1/3] build-sys: use pkgconfig and lz4 and bump version

[Dave Reisner]

On Sun, Dec 07, 2014 at 07:32:38PM +0100, Zbigniew Jędrzejewski-Szmek wrote:
> The new frame api should be released in v. 125.
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 356a3c3d67..94e6a3b54a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -565,7 +565,7 @@ AM_CONDITIONAL(HAVE_XZ, [test "$have_xz" = "yes"])
>  have_lz4=no
>  AC_ARG_ENABLE(lz4, AS_HELP_STRING([--enable-lz4], [Enable optional LZ4 support]))
>  AS_IF([test "x$enable_lz4" == "xyes"], [
> -        AC_CHECK_HEADERS(lz4.h,
> +        PKG_CHECK_MODULES(LZ4, [ liblz4 >= 125 ],
>                 [AC_DEFINE(HAVE_LZ4, 1, [Define in LZ4 is available]) have_lz4=yes],
>                 [AC_MSG_ERROR([*** LZ4 support requested but headers not found])])

This is potentially misleading. The headers might be found, but miss the
version requirement. We do a similar dance for kmod as we explicitly
depend on kmod>=15.

>  ])
> -- 
> 1.9.3
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel