[systemd-devel] [PATCH] Set loaded_policy in smack_setup()
casey.schaufler at intel.com
Tue Feb 18 08:26:38 PST 2014
> -----Original Message-----
> From: Lennart Poettering [mailto:lennart at poettering.net]
> Sent: Tuesday, February 18, 2014 8:19 AM
> To: Łukasz Stelmach
> Cc: Schaufler, Casey; systemd-devel at lists.freedesktop.org
> Subject: Re: [systemd-devel] [PATCH] Set loaded_policy in smack_setup()
> On Tue, 18.02.14 14:39, Łukasz Stelmach (l.stelmach at samsung.com) wrote:
> > Do you have any plans to push the commit upstream?
Commit depends on a change to libsmack that is still under discussion. It shouldn't get pushed until the libsmack changes are in.
> > Footnotes:
> >  http://article.gmane.org/gmane.comp.sysutils.systemd.devel/15596
> > 
> Both patches look pretty OK.  is entirely OK. Regarding :
> - Tabs vs. spaces
> - Please do not do #defines for /dev. Also, do not hardcode the length
> like this. Instead use sizeof("/dev/)-1 or so. That said, best is
> actually to just use path_startswith().
> Other than that looks fine...
> Lennart Poettering, Red Hat
More information about the systemd-devel