[systemd-devel] [PATCH] Set loaded_policy in smack_setup()

[Schaufler, Casey]

> -----Original Message-----
> From: Schaufler, Casey
> Sent: Tuesday, February 18, 2014 8:27 AM
> To: Lennart Poettering; Łukasz Stelmach
> Cc: systemd-devel at lists.freedesktop.org; Schaufler, Casey
> Subject: RE: [systemd-devel] [PATCH] Set loaded_policy in smack_setup()
> 
> > -----Original Message-----
> > From: Lennart Poettering [mailto:lennart at poettering.net]
> > Sent: Tuesday, February 18, 2014 8:19 AM
> > To: Łukasz Stelmach
> > Cc: Schaufler, Casey; systemd-devel at lists.freedesktop.org
> > Subject: Re: [systemd-devel] [PATCH] Set loaded_policy in smack_setup()
> >
> > On Tue, 18.02.14 14:39, Łukasz Stelmach (l.stelmach at samsung.com) wrote:
> >
> > > Do you have any plans to push the commit[1] upstream?
> 
> Commit[1] depends on a change to libsmack that is still under discussion. It
> shouldn't get pushed until the libsmack changes are in.


Whoops! My mistake. There is no libsmack dependency. I misread the code. This should be fine to take at some point.
 
> > >
> > > Footnotes:
> > >
> > > [1] http://article.gmane.org/gmane.comp.sysutils.systemd.devel/15596
> > > [2]
> >
> https://review.tizen.org/git/?p=platform/upstream/systemd.git;a=commitdi
> > ff;h=8445e9990936244ccb0a1023baa5abf77f3ae2c4
> >
> > Both patches look pretty OK. [1] is entirely OK. Regarding [2]:
> >
> > - Tabs vs. spaces
> >
> > - Please do not do #defines for /dev. Also, do not hardcode the length
> >   like this. Instead use sizeof("/dev/)-1 or so. That said, best is
> >   actually to just use path_startswith().
> >
> > Other than that looks fine...
> >
> > Lennart
> >
> > --
> > Lennart Poettering, Red Hat