[systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

[Yang Chengwei]

On Thu, Jan 16, 2014 at 02:56:27AM +0100, Zbigniew Jędrzejewski-Szmek wrote:
> On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote:
> > The situation is: by default, we get a "auto" value for kmod compiling
> > option, so if we found required kmod files, then we build it with kmod
> > enabled, otherwise, just build without kmod and do not complain to user.
> > 
> > However, currently, if kmod version < 15 available in machine, and build
> > with default option, say no explicitly with "--enable/disable-kmod",
> > then the configure will fail with
> > 
> > ...
> > checking for KMOD... no
> > configure: error: *** kmod version >= 15 not found
> > ...
> This is on purpose.

I'm not sure if this is worth, given that kmod may not available in some
distro version, for example, ubuntu 12.04, so you're expecting us to
replace kmod from OS repo or upgrade our OS to do systemd development. A
little dominating to user I think.

--
Thanks,
Chengwei

> 
> commit c4955740969d7ba8ba43b024bca1a0a5b56eb8e8
> Author: Tom Gundersen <teg at jklm.no>
> Date:   Tue Jul 9 00:12:35 2013 +0200
> 
>     configure: fail if out-of-date kmod found and kmod not disabled
>     
>     Almost everyone wants kmod support, so don't fail silently if the libs are
>     out-of-date.
>     
>     kmod can still be explicitly disabled and if it is not found at all, we still
>     default to disabling it.
> 
> Zbyszek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20140116/88893c33/attachment.pgp>