[systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

[Zbigniew Jędrzejewski-Szmek]

On Thu, Jan 16, 2014 at 10:05:23AM +0800, Yang Chengwei wrote:
> On Thu, Jan 16, 2014 at 02:56:27AM +0100, Zbigniew Jędrzejewski-Szmek wrote:
> > On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote:
> > > The situation is: by default, we get a "auto" value for kmod compiling
> > > option, so if we found required kmod files, then we build it with kmod
> > > enabled, otherwise, just build without kmod and do not complain to user.
> > > 
> > > However, currently, if kmod version < 15 available in machine, and build
> > > with default option, say no explicitly with "--enable/disable-kmod",
> > > then the configure will fail with
> > > 
> > > ...
> > > checking for KMOD... no
> > > configure: error: *** kmod version >= 15 not found
> > > ...
> > This is on purpose.
> 
> I'm not sure if this is worth, given that kmod may not available in some
> distro version, for example, ubuntu 12.04, so you're expecting us to
> replace kmod from OS repo or upgrade our OS to do systemd development. A
> little dominating to user I think.
No, the idea is to prevent accidental breakage when kmod is available,
but in an older version. Since this is fairly important functionality,
it is deemed better to require explicit override in this case.

Zbyszek