[systemd-devel] [PATCH] sd-resolv: declare functions from .h public

Lennart Poettering lennart at poettering.net
Fri Jan 17 11:37:55 PST 2014


On Tue, 14.01.14 19:29, Tom Gundersen (teg at jklm.no) wrote:

> 
> Hi Daniel,
> 
> I guess we should only do this once we decide to export the API. I
> guess we won't be doing that for a few releases (we'll use it
> internally first to make sure it is the way we want it).
> 
> Or are there any benefits to these annotations even when the symbols
> are not exported?

Well, sd-resolve is in the same situation here as sd-event or sd-bus
are: not public APIs yet, but probably very soon. And given that
sd-event, sd-bus, sd-memfd, ... all have the _public_ stuff sd-resolve.h
probably should too.

I'd merge the patch, alas it doesn't apply anymore. Daniel, could you
rebase please?

Also, the symbols exposed by sd_resolve need to be added to the .sym
file, too.

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list