[systemd-devel] [RFC PATCH 1/2] Replace mkostemp+unlink with open(O_TMPFILE)

[Zbigniew Jędrzejewski-Szmek]

On Mon, Jan 27, 2014 at 07:11:49PM +0100, Lennart Poettering wrote:
> On Mon, 27.01.14 19:09, Lennart Poettering (lennart at poettering.net) wrote:
> 
> > I just really don't like exposing two codepaths to the user. I want one
> > version that works for everybody, because people are highly like to
> > misuse this otherwise. Logging is so basic that people shouldn't be able
> > to fuck it up...
> 
> To clarify this: I neither like having two codepaths essentially doing
> the same here, and one tested and the other one barely... Nor do I like
> even given the caller control about this. I mean, we can make sure for
> our own code that we handle async signal safety properly, but it appears
> like a difficult request to make to other people...
Yeah. The idea of two codepaths was crazy. I've now committed a version
which reimplements mkostemp and provides the guarantee always.

Zbyszek