[systemd-devel] [systemd-commits] 6 commits - man/systemd.network.xml network/80-container-host0.network src/libsystemd-network src/network src/systemd units/local-fs.target

Lennart Poettering lennart at poettering.net
Sun Jun 29 12:21:18 PDT 2014


On Sun, 29.06.14 07:25, Tom Gundersen (tomegun at kemper.freedesktop.org) wrote:

> +
> +        FOREACH_WORD(word, len, string, state) {
> +                /* WORD FORMAT: dst_ip/dst_prefixlen,gw_ip */
> +                _cleanup_free_ char* entry;

missing initialization to NULL. 

> +                char *tok, *tok_end;
> +                unsigned n;
> +                int r;
> +
> +                if (!GREEDY_REALLOC(routes, allocated, size + 1))
> +                        return -ENOMEM;
> +
> +                entry = strndup(word, len);

Missing OOM check.

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list