[systemd-devel] [systemd-commits] 6 commits - man/systemd.network.xml network/80-container-host0.network src/libsystemd-network src/network src/systemd units/local-fs.target

[Tom Gundersen]

On Sun, Jun 29, 2014 at 9:21 PM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Sun, 29.06.14 07:25, Tom Gundersen (tomegun at kemper.freedesktop.org) wrote:
>
>> +
>> +        FOREACH_WORD(word, len, string, state) {
>> +                /* WORD FORMAT: dst_ip/dst_prefixlen,gw_ip */
>> +                _cleanup_free_ char* entry;
>
> missing initialization to NULL.

Thanks. Fixed.

>> +                char *tok, *tok_end;
>> +                unsigned n;
>> +                int r;
>> +
>> +                if (!GREEDY_REALLOC(routes, allocated, size + 1))
>> +                        return -ENOMEM;
>> +
>> +                entry = strndup(word, len);
>
> Missing OOM check.

Already got a patch from Susant for this. Pushed both.

-t