[systemd-devel] [PATCH v2] journalctl: Allow to disable line cap with --lines=all

[Lennart Poettering]

On Sun, 31.08.14 11:12, Jan Janssen (medhefgo at web.de) wrote:

> @@ -68,7 +68,7 @@ static bool arg_follow = false;
>  static bool arg_full = true;
>  static bool arg_all = false;
>  static bool arg_no_pager = false;
> -static int arg_lines = -1;
> +static int arg_lines = -2;

Humm. No, please don't! This is ugly. Don't introduce constant values
without giving them a name, expecting everybody to remember the
numeric values you assign.

I have have now pushed a patch that fixes this and introduces proper
enum values ARG_LINE_DEFAULT and ARG_LINE_ALL to use.

Lennart

-- 
Lennart Poettering, Red Hat