[systemd-devel] [PATCH] firstboot: remove extra paranoia in --root checking

[Lennart Poettering]

On Thu, 28.08.14 13:30, Dave Reisner (dreisner at archlinux.org) wrote:

> Some package managers will chroot before running post-install and
> post-upgrade scripts. Doing this prevents systemd-firstboot from being
> used piecemeal at installation or upgrade time, as the --root=/ will be
> "cleverly" ignored.
> 
> There's already enough sanity checks in this tool that we don't also
> need add "intelligence" on top of the --root parameter. If a sys-admin
> wants to run this tool with --root=/, I see no reason why we should
> actively stop them.

Hmmm, I now commited a different patch that just removes the
--setup-machine-id refusal to operate on /. After all, if the machine
id is really missing in the root fs there's no reason to block this
off.

This should fix your issue too, right? Could you check please?

(Reducing arg_root == "/" into arg_root = NULL is really more about
optimization I guess, so I figured we should leave it in).

Lennart

-- 
Lennart Poettering, Red Hat