[systemd-devel] [PATCH v4] udev hwdb: Support shipping pre-compiled database in system images

[Martin Pitt]

Hey Zbyszek,

Zbigniew Jędrzejewski-Szmek [2014-10-24 19:45 +0200]:
> This enumeration is also used below... The definition should be shared.
> You might want to also consider using NULSTR_FOREACH for iteration.

Ah, thanks for pointing that out.

> This function should have the prototype of 'int open_hwdb_bin(const char **path, FILE *file)'
> and return a proper value on error. Right now the return value is passed
> through errno, which works but is inelegant.

OK. Personally I prefer "ret < 0" and errno as that's the standard
POSIX way and also allows using %m etc., but if strerror(-retval) is
the systemd style, fair enough.

The updated patch fixes both now.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-udev-hwdb-Support-shipping-pre-compiled-database-in-.patch
Type: text/x-diff
Size: 9443 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20141024/8d76d30f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20141024/8d76d30f/attachment.sig>