[systemd-devel] [PATCH 0/5] Coverity fixes

philippedeswert at gmail.com philippedeswert at gmail.com
Wed Sep 10 02:20:37 PDT 2014


From: Philippe De Swert <philippedeswert at gmail.com>

Hi,

Yesterday I finally got to revive the systemd Coverity project on
scan.coverity.org Unfortunately to see the errors reported you need
to sign up, but I will make sure to approve requests for seeing the
"bugs" whenever they show up.

Also I quickly made some quick fixes (although since it was late at night 
yesterday there might be a few that were too quick ;) )
There is a lot of work to do reviewing the error reports (as some are 
probably false positives) and fixing them. About 500 errors and an error
defect density of 2.5 atm.

Cheers,

Philippe

Philippe De Swert (5):
  [use after free] Avoid using m->kdbus after freeing it.
  [use after free] pattern is already freed, so do not dereference it in
    the error print
  [uninitialized] No need to check if num is < 0
  [memleak] Do not leak mmapped area when other memory allocations fail.
  [memleak] Actually unref the buscreds on failure.

 src/journal/coredumpctl.c               |  4 ++--
 src/journal/mmap-cache.c                | 10 +++++++---
 src/libsystemd-terminal/idev-keyboard.c |  3 ---
 src/libsystemd/sd-bus/bus-message.c     |  6 +++---
 src/libsystemd/sd-bus/sd-bus.c          |  4 +++-
 5 files changed, 15 insertions(+), 12 deletions(-)

-- 
1.8.3.2



More information about the systemd-devel mailing list