[systemd-devel] [ANNOUNCE] Git development moved to github

Lennart Poettering lennart at poettering.net
Wed Jun 10 02:48:17 PDT 2015


On Wed, 10.06.15 06:44, Martin Pitt (martin.pitt at ubuntu.com) wrote:

> Filipe Brandenburger [2015-06-09 12:55 -0700]:
> > I think a more productive advice would be for reviewers to avoid using
> > line comments for anything that is wanted for posterity and instead
> > only use them to say "typo" or "comment here" or to point out what
> > exactly in the code the comment on the main thread is making reference
> > to. Wouldn't you think that would be preferrable?
> 
> FWIW, I don't like it that much either, but so far I still find this
> the best compromise. Creating and keeping track of multiple PRs and
> issues even for simple patches where there's a typo or a small style
> bugs is more unwieldy than losing the line comments IMHO.
> 
> That said, I'll abide to Lennart's final decision to that of course.

I'd like to try it with new PRs for each review first. And we should
agressively "lock" old PRs to ensure people stop commenting on them as
soon as the new PR is around. There's a button on the lower right to
lock PRs...

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list