[systemd-devel] [PATCH 4/5] fsckd: check if plymouth is running before attempting connection

Didier Roche didrocks at ubuntu.com
Tue Mar 10 10:00:23 PDT 2015


Le 10/03/2015 11:44, Lennart Poettering a écrit :
> On Tue, 10.03.15 11:34, Didier Roche (didrocks at ubuntu.com) wrote:
>
> I think it would make more sense to return 0 when ply isn't running,
> and 1 if it is, no?

Did this in the attached patch. Due to this, I needed then to return 1 
even if we did not reconnect to plymouth but was already connected, 
which slightly break the paradigm of "return 0 if we did nothing, and 1 
if the action changed something and is successful".
Is that ok?

Cheers,
Didier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fsckd-check-if-plymouth-is-running-before-attempting.patch
Type: text/x-diff
Size: 1290 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150310/4888c8aa/attachment.patch>


More information about the systemd-devel mailing list