[systemd-devel] [PATCH 4/5] fsckd: check if plymouth is running before attempting connection

Tom Gundersen teg at jklm.no
Mon Mar 16 10:33:59 PDT 2015

On Tue, Mar 10, 2015 at 6:00 PM, Didier Roche <didrocks at ubuntu.com> wrote:
> Le 10/03/2015 11:44, Lennart Poettering a écrit :
>> On Tue, 10.03.15 11:34, Didier Roche (didrocks at ubuntu.com) wrote:
>> I think it would make more sense to return 0 when ply isn't running,
>> and 1 if it is, no?
> Did this in the attached patch. Due to this, I needed then to return 1 even
> if we did not reconnect to plymouth but was already connected, which
> slightly break the paradigm of "return 0 if we did nothing, and 1 if the
> action changed something and is successful".
> Is that ok?

This looks good to me. Applied (with the needed revert).



More information about the systemd-devel mailing list