[systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

Lennart Poettering lennart at poettering.net
Fri May 15 11:37:43 PDT 2015


On Mon, 27.04.15 12:09, Lukas Rusak (lorusak at gmail.com) wrote:

> I feel like this is already accomplished. The completion function
> "_sd_machines" already lists the running containers.
> 
> Otherwise currently "_available_machines" is only used for "machinectl
> start".
> see,
>           list*|cancel-transfer|pull-tar|pull-raw|pull-dkr)
>             msg="no options" ;;
>           start)
>             _available_machines ;;
>           *)
>             _sd_machines
> 
> All other functions (other than list-images, list-transfers, list,
> cancel-transfer, pull-tar, pull-raw, and pull-dkr) use the already
> implemented "_sd_machines" function to list currently running machines.
> 
> So, if you would like I can change "_available_machines" to "_available_images"
> and "__get_available_machines" to "__get_available_images" if this makes
> more sense.

BTW: just a heads up: I will not merge zsh patches, as I don't use zsh
and it's not my area of expertise. 

Zbigniew, can you please look into these patches from Lukas?

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list