[systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

[Zbigniew Jędrzejewski-Szmek]

On Mon, Apr 27, 2015 at 12:09:47PM -0700, Lukas Rusak wrote:
> I feel like this is already accomplished. The completion function
> "_sd_machines" already lists the running containers.
> 
> Otherwise currently "_available_machines" is only used for "machinectl
> start".
> see,
>           list*|cancel-transfer|pull-tar|pull-raw|pull-dkr)
>             msg="no options" ;;
>           start)
>             _available_machines ;;
>           *)
>             _sd_machines
> 
> All other functions (other than list-images, list-transfers, list,
> cancel-transfer, pull-tar, pull-raw, and pull-dkr) use the already
> implemented "_sd_machines" function to list currently running machines.
> 
> So, if you would like I can change "_available_machines" to "_available_images"
> and "__get_available_machines" to "__get_available_images" if this makes
> more sense.
Yes, please do that. Also change the hint to say 'images'/'no images'.
You'll have to do that as a separate commit: current patches are a big
improvement to existing completions, and this is a cosmetic fix, so
I'll push them now.

Zbyszek