[systemd-devel] [PATCH] detect-virt: do not return exit failure code when the state is none

Uoti Urpala uoti.urpala at pp1.inet.fi
Thu May 24 09:56:22 UTC 2018


On Thu, 2018-05-24 at 13:47 +0800, Lee, Chun-Yi wrote:
> Currently the systemd-detect-virt returns exit failure code when it
> detected none state. But actually the none state is still a valid
> state but not a process failed.
> 
> This patch changes the logic to return success code when the state
> is none. It can avoid that subsequent activity is blocked by the
> failure code of systemd-detect-virt process.

This is explicitly documented as "If a virtualization technology is
detected, 0 is returned, a non-zero code otherwise.". So other things
could be relying on the current behavior, and any attempts to change it
 despite that should at least modify the documentation too.



More information about the systemd-devel mailing list