[systemd-devel] use a cache for resolving tags in libmount_parse() api

[Rajmohan. R]

Hi Systemd-devel Team,
I am trying to include a function mnt_new_cache() in systemd.
I had changed the signature of a few existing function of systemd.

I get the below compile error.


kpit at L-16522:systemd$ ninja -C build
ninja: Entering directory `build'
[833/2203] Linking target systemd
FAILED: systemd
cc  -o systemd systemd.p/src_core_main.c.o systemd.p/src_core_crash-handler.c.o -Wl,--as-needed -Wl,--no-undefined -fstack-protector '-Wl,-rpath,$ORIGIN/src/core:$ORIGIN/src/shared' -Wl,-rpath-link,/home/kpit/a1-velai/code/systemd/4mgithub/another-sd/systemd/build/src/core -Wl,-rpath-link,/home/kpit/a1-velai/code/systemd/4mgithub/another-sd/systemd/build/src/shared -Wl,--start-group src/core/libsystemd-core-256.so src/shared/libsystemd-shared-256.so -Wl,--end-group -Wl,--fatal-warnings -Wl,-z,now -Wl,-z,relro -Wl,--warn-common
/usr/bin/ld: systemd.p/src_core_main.c.o: undefined reference to symbol 'mnt_new_cache@@MOUNT_2.19'
/usr/bin/ld: /lib/x86_64-linux-gnu/libmount.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
[842/2203] Generating src/test/test-libsystemd-sym.c with a custom command (wrapped by meson to capture output)
ninja: build stopped: subcommand failed.
kpit at L-16522:systemd$

Anything wrong in my compilation though i had included necessary header file.
Signature change in function is present and will it be accepted, assuming compilation is successful.
I read in contribution webpage, that if there occurs signature change in function, then those change shall be ignored or dimissed or if there is a possbility of having the change as an interface, systemd team will consider after reviewing.

Please let me know the above queries.
Thank you
rajmohan
This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/systemd-devel/attachments/20240508/c4f0c4c6/attachment.htm>