[Bug 24120] Refactor the McdDispatcher

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24120





--- Comment #32 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-10-20 11:59:33 PST ---
(In reply to comment #31)
> (In reply to comment #27)
> > dr4.5:
> > 
> > +    channels_array = _mcd_dispatch_operation_dup_channel_details
> > +        (context->operation);
> > 
> > Not putting the ( on the same line as the function name tricks cscope into not
> > realising this is a function call.  Not that big a deal I guess.
> 
> I'll fix that, it's a more common style I think.

In fact, I re-wrap that line when I move mcd_dispatcher_handle_channels into
the CDO in the second-from-last patch of chapter 4.7, so I won't bother.

> > +    /* if it was a channel request, and it was cancelled, then the whole
> > +     * context should be aborted */
> > 
> > This comment no longer makes sense inside MDO.
> 
> True, I'll fix it.

Fixed in the branch. I haven't rebased.

> > +        /* remove the context from the list of active contexts */
> > +        priv->operations = g_list_remove (priv->operations,
> > context->operation);
> > Comment doesn't match the implementation. I think the comment is more correct.
> 
> We do both (the contexty version is half a dozen lines below); the comment is
> wrong here, and I'll fix it.

... actually, I'd rather not, since I deleted that comment halfway through 4.7.

> > > McdDispatcher: match_filters: operate entirely in terms of properties
> > 
> > the immutable_properties() paths assert that channel_properties is not NULL;
> > the requested_properties() path does not, and nor does the "both" path.
> 
> I'll look into it.

In all three cases channel_properties shouldn't be NULL. I'd rather do this
after 4.7, since the code making the assertion moves into the CDO during the
4.7 branch (and is then badgered by the branch I'm currently working on, but
I'll rebase that).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.