[Bug 24120] Refactor the McdDispatcher

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24120





--- Comment #33 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-10-20 12:27:16 PST ---
(In reply to comment #32)
> In all three cases channel_properties shouldn't be NULL. I'd rather do this
> after 4.7, since the code making the assertion moves into the CDO during the
> 4.7 branch (and is then badgered by the branch I'm currently working on, but
> I'll rebase that).

Fixed at the end of dr4.7, now.

(In reply to comment #31)
> > Would it be clearer to make _mcd_dispatch_operation_new() deep-copy the
> > channels?
> 
> Possibly. The underlying problem is that the property is of type
> G_TYPE_POINTER, which doesn't do any reffing or copying or anything, rather
> than a boxed type that deep-copies the GList automatically.
> 
> I *think* we're now far enough through that making this conventional wouldn't
> cause conflicts later, but just in case, can I defer this to the end?

In a patch appended to dr4.7, I've made mcd_dispatch_operation_set_property()
deep-copy the channels, so _mcd_dispatch_operation_new doesn't (effectively)
steal them; made _mcd_dispatcher_enter_state_machine not steal them; and made
_mcd_dispatcher_take_channels free them, for the moment, since its name is
sufficient indication that it steals things, I think.

Renaming _mcd_dispatcher_take_channels and making it not free the GList can be
a job for some future point.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.