[Bug 24764] Provide API for requesting delivery reports

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24764





--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-10-28 10:20:37 PST ---
>diff --git a/TelepathyQt4/text-channel.cpp b/TelepathyQt4/text-channel.cpp
>index be82cff..ccf897d 100644
>--- a/TelepathyQt4/text-channel.cpp
>+++ b/TelepathyQt4/text-channel.cpp
>@@ -102,6 +102,7 @@ struct TELEPATHY_QT4_NO_EXPORT TextChannel::Private
>     static void introspectMessageQueue(Private *self);
>     static void introspectMessageCapabilities(Private *self);
>     static void introspectMessageSentSignal(Private *self);
>+    static void introspectMessageDeliveryReports(Private *self);
> 
>     void updateInitialMessages();
>     void updateCapabilities();

This doesn't introspect anything. Call it enableMessageDeliveryReports?

>@@ -180,6 +185,14 @@ TextChannel::Private::Private(TextChannel *parent)
>         this);
>     introspectables[FeatureMessageSentSignal] = introspectableMessageSentSignal;
> 
>+    ReadinessHelper::Introspectable introspectableMessageDeliveryReports(
>+        QSet<uint>() << 0,                                                      // makesSenseForStatuses
>+        Features() << Channel::FeatureCore,                                     // dependsOnFeatures (core)

Shouldn't it depend on FeatureMessageQueue too, since that's how you actually
*get* the reports?

>+/**
>+ * \var Feature TextChannel::FeatureMessageDeliveryReports
>+ * The messageReceived will be emitted as soon as a message of type
>+ * ChannelTextMessageTypeDeliveryReport is received.
>+ * Note that delivery report needs to be supported. To check if delivery report
>+ * is supported enable FeatureMessageCapabilities and check
>+ * deliveryReportingSupport().
>+ */

I don't like this description. How about this?

 * When enabled, delivery reports will be requested. Delivery reports are
 * received in the same way as ordinary messages, but with type
 * ChannelTextMessageTypeDeliveryReport, so enabling this feature also enables
 * FeatureMessageQueue. See the Telepathy D-Bus API Specification for examples
 * of how delivery reports are represented.
 *
 * Even if this flag is set, some protocols never have delivery reports;
 * meanwhile, on some protocols, delivery reports for failure, success or
 * both will arrive even if this flag is <em>not</em> set. To check whether
 * you can expect to get delivery reports, enable FeatureMessageCapabilities
 * and check deliveryReportingSupport().

(Hmm, perhaps this Feature should imply FeatureMessageCapabilities too...)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.