[Bug 24764] Provide API for requesting delivery reports

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24764





--- Comment #2 from Andre Moreira Magalhaes <andrunko at gmail.com>  2009-10-30 04:54:03 PST ---
(In reply to comment #1)
> >diff --git a/TelepathyQt4/text-channel.cpp b/TelepathyQt4/text-channel.cpp
> >index be82cff..ccf897d 100644
> >--- a/TelepathyQt4/text-channel.cpp
> >+++ b/TelepathyQt4/text-channel.cpp
> >@@ -102,6 +102,7 @@ struct TELEPATHY_QT4_NO_EXPORT TextChannel::Private
> >     static void introspectMessageQueue(Private *self);
> >     static void introspectMessageCapabilities(Private *self);
> >     static void introspectMessageSentSignal(Private *self);
> >+    static void introspectMessageDeliveryReports(Private *self);
> > 
> >     void updateInitialMessages();
> >     void updateCapabilities();
> 
> This doesn't introspect anything. Call it enableMessageDeliveryReports?
Done

> >@@ -180,6 +185,14 @@ TextChannel::Private::Private(TextChannel *parent)
> >         this);
> >     introspectables[FeatureMessageSentSignal] = introspectableMessageSentSignal;
> > 
> >+    ReadinessHelper::Introspectable introspectableMessageDeliveryReports(
> >+        QSet<uint>() << 0,                                                      // makesSenseForStatuses
> >+        Features() << Channel::FeatureCore,                                     // dependsOnFeatures (core)
> 
> Shouldn't it depend on FeatureMessageQueue too, since that's how you actually
> *get* the reports?
Done

> >+/**
> >+ * \var Feature TextChannel::FeatureMessageDeliveryReports
> >+ * The messageReceived will be emitted as soon as a message of type
> >+ * ChannelTextMessageTypeDeliveryReport is received.
> >+ * Note that delivery report needs to be supported. To check if delivery report
> >+ * is supported enable FeatureMessageCapabilities and check
> >+ * deliveryReportingSupport().
> >+ */
> 
> I don't like this description. How about this?
> 
>  * When enabled, delivery reports will be requested. Delivery reports are
>  * received in the same way as ordinary messages, but with type
>  * ChannelTextMessageTypeDeliveryReport, so enabling this feature also enables
>  * FeatureMessageQueue. See the Telepathy D-Bus API Specification for examples
>  * of how delivery reports are represented.
>  *
>  * Even if this flag is set, some protocols never have delivery reports;
>  * meanwhile, on some protocols, delivery reports for failure, success or
>  * both will arrive even if this flag is <em>not</em> set. To check whether
>  * you can expect to get delivery reports, enable FeatureMessageCapabilities
>  * and check deliveryReportingSupport().
Verbatim

> (Hmm, perhaps this Feature should imply FeatureMessageCapabilities too...)
I didn't change this as I don't have a strong opinion here. I believe enabling
delivery reports is independent of knowing if delivery reports are supported.
It's like, _if_ reports are supported, enable it.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.