[Bug 24061] TpAccount, TpAccountManager: add convenience API similar to libempathy's

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24061


Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xclaesse at gmail.com




--- Comment #16 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2009-09-25 11:46:17 PST ---
Xavier made some comments online regarding my branch too:

06:24 < Zdra> jonnylamb: _tp_account_connection_ready_cb() should not call
g_object_notify (G_OBJECT (account), 
              "connection"); because you don't return only ready TpConnection
anymore
06:35 < Zdra> jonnylamb: note that TpAccount retuning non-ready TpConnection
has implications in empathy
06:35 < Zdra> EmpathyAccount was returning NULL if the connection was not ready
06:35 < Zdra> and all the empathy code always assume objects are ready
06:36 < Zdra> jonnylamb: for example there are places when it gets the
connection from an account in the 
              EmpathyAccountChooser
06:36 < Zdra> jonnylamb: then make some channel request with that connection
without checking if it was ready
06:37 < Zdra> basically some if(connection!=NULL) should be replaced by
if(connection!=NULL&&tp_connection_is_ready())
06:49 < Zdra> jonnylamb, What's the rational for calling
_tp_account_become_ready in the middle of _tp_account_update 
              instead of the end?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.