[Bug 24061] TpAccount, TpAccountManager: add convenience API similar to libempathy's

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24061





--- Comment #17 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-09-25 11:52:06 PST ---
(In reply to comment #16)
> Xavier made some comments online regarding my branch too:
> 
> 06:24 < Zdra> jonnylamb: _tp_account_connection_ready_cb() should not call
> g_object_notify (G_OBJECT (account), 
>               "connection"); because you don't return only ready TpConnection
> anymore
> 06:35 < Zdra> jonnylamb: note that TpAccount retuning non-ready TpConnection
> has implications in empathy

I think Empathy should have a wrapper function that only returns ready
TpConnections, then (this can be added while porting).

TpConnection *
empathy_account_get_ready_connection (...)
{
  TpConnection *c = tp_account_get_connection (...);

  if (! tp_connection_is_ready (c))
    c = NULL;

  return c;
}

If we need it badly enough, we can add tp_account_get_ready_connection later,
or even add that extra guarantee. However, making tp_account_get_connection
*not* guarantee to produce a ready connection is not a safe change to make
later.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.