[Bug 24061] TpAccount, TpAccountManager: add convenience API similar to libempathy's

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24061





--- Comment #18 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-09-25 12:15:26 PST ---
Aargh, TpAM also has signals I hadn't looked at...

+  /**
+   * TpAccountManager::account-changed:
+   * @manager: a #TpAccountManager
+   * @account: a #TpAccount
+   *
+   * Emitted when an account @manager is changed.

What?! What does that even mean?

It seems to never be emitted, anyway. Drop it?

+  /**
+   * TpAccountManager::account-connection-changed:

Is this guaranteed by FeatureCore to be emitted? If so, are you sure it should
be an API guarantee that it is?

(If you're not sure, the shortest path to fewer API guarantees is to #if 0 it,
and consider adding it later)

+  /**
+   * TpAccountManager::new-connection

Likewise, but more expensive to emit (it's creating a TpConnection with no
guarantee that anyone cares about it - the sugar-presence-service
anti-pattern).

+  /**
+   * TpAccountManager::global-presence-changed:

This should have been renamed when tp_account_manager_get_global_presence was.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.