[Bug 27201] implement Messages interface

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 5 13:31:41 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27201

--- Comment #6 from Olivier Le Thanh Duong <olivier at lethanh.be> 2010-04-05 04:31:41 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > just tested, it doesn't emit it if we don't add the decorator
> 
> Odd. Well use the interface constant instead of "org.freedes..."
> 
Done
> +    # run in an glib's idle so we emit the signal after either Send or
> SendMessage return
> +    @async
> +    def _signal_text_sent(self, timestamp, message_type, text):
> 
> dbus-python has a better way of doing this instead of throwing things in an
> idle. See CreateChannel in tp-python's ConnectionInterfaceRequests.
> 
> Other than that yeah let's go. Ping me when you've updated your branch.

I know about it but I actually found it far less readable than the simple async
decorator. However if you feel strongly about it the top commit of the branche
does that

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the telepathy-bugs mailing list