[Bug 27622] Pluggable SASL authentication

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Apr 20 18:30:13 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27622

--- Comment #9 from Will Thompson <will.thompson at collabora.co.uk> 2010-04-20 09:30:12 PDT ---
A few words on the async result version of the branch:

on_handler_responded shouldn't be assuming the result it's given is a
SimpleAsyncResult. Instead, wocky_sasl_handler_handle_challenge and
handle_success should have an _async suffix, and have corresponding _finish()
functions (rather than the handler calling wocky_sasl_handler_task_finished()
in either case) which returns the response.

I fear that, if the WockySaslAuth dies before the call to
wocky_sasl_handler_handle_challenge() finishes, we'll die when the handler
calls the callback.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list