[Bug 27622] Pluggable SASL authentication

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27622

--- Comment #10 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-04-20 12:32:42 PDT ---
(In reply to comment #9)
> A few words on the async result version of the branch:
> 
> on_handler_responded shouldn't be assuming the result it's given is a
> SimpleAsyncResult. Instead, wocky_sasl_handler_handle_challenge and
> handle_success should have an _async suffix, and have corresponding _finish()
> functions (rather than the handler calling wocky_sasl_handler_task_finished()
> in either case) which returns the response.
> 
> I fear that, if the WockySaslAuth dies before the call to
> wocky_sasl_handler_handle_challenge() finishes, we'll die when the handler
> calls the callback.

Obviously I didn't understand how to use GSimpleAsyncResult correctly. After
reading this comment a few times, and after some experimentation, I think I got
something a bit more sane, it's pushed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.