[Bug 22304] Avatars interface doesn't implement D-Bus properties

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=22304

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2010-04-22 06:11:19 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Looks fine. Does it work? Is there a simple smoke-test in Gabble we could
> > steal?
> 
> Good idea. I stole the one from Gabble and adjusted it to also try before
> connecting.

Could the adjustment be merged back to Gabble too?

> (In reply to comment #1)
> > One thing I'm slightly unsure about is that
> > haze_connection_avatars_properties_getter can be called before the Connection
> > is CONNECTED. Is it safe for it to assume that the account's prpl_info will be
> > present already?
> 
> It turns out this wasn't safe, and crashed Haze. Fixed in my revised branch by
> returning dummy values before CONNECTED (the spec allows this).

Good catch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.