[Bug 24618] [0.11] add TpStringPool, a refcounted pool of strings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=24618

Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #9 from Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> 2010-04-22 06:16:38 PDT ---
I finally understood why some tests where failing.

It's not possible to clear the GDataList after disposing the string pool in the
handle repo.

See afb3ae5e9ec1f5f6765be12018fc8911ce3c874f.

About it there are three option I can do:
1) (they current way as per afb3ae5e9ec1f5f6765be12018fc8911ce3c874f) call
g_datalist_clear() in dispose. It's safe to call it more than once so it
shouldn't be a problem to be in dispose().

2) analyse the problem better and fix the problem at its root (I'd probably
open a bug and solve it independently later, unless you see some collateral
effect)


The rest of the branch is actually several diffs that do not do much in terms
of code. Mainly renaming, improving doc, etc.

When the review cycle will be done, I'll stash them all in just some patches,
mainly the TpStringPool creation, the Handle repo application of TpStringPool,
plus a commit per fix that should not be stashed with them.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.