[Bug 27772] de-obfuscate self->priv access

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27772

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|review+                     |

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-22 10:54:04 PDT ---
(In reply to comment #1)
> TplLogStore is a GInterface, which I think do not change the patch. Can you
> update the commit's comment before publishing the branch, please?

Done.

(In reply to comment #2)
> This branch mostly looks good, though I think we should go a step farther and
> only deref self (for self->priv) after g_return_if_fail (TP_IS_<TYPE> (self));

Done, in every case where it seemed to matter, and some that didn't. Re-review
please?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.