[Bug 27772] de-obfuscate self->priv access

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27772

--- Comment #8 from Travis Reitter <travis.reitter at collabora.co.uk> 2010-04-22 14:21:59 PDT ---
(In reply to comment #5)
> (In reply to comment #2)
> > This branch mostly looks good, though I think we should go a step farther and
> > only deref self (for self->priv) after g_return_if_fail (TP_IS_<TYPE> (self));
> 
> Not a regression - GET_PRIV dereferenced self->priv just as much as my branch
> does.
> 
> I'm appending some patches, though.

Right - it wasn't a regression, but we might as well fix those while we're at
it.

(In reply to comment #7)
> (In reply to comment #2)
> > This branch mostly looks good, though I think we should go a step farther and
> > only deref self (for self->priv) after g_return_if_fail (TP_IS_<TYPE> (self));
> 
> Done, in every case where it seemed to matter, and some that didn't. Re-review
> please?

Looks good to me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.