[Bug 20768] Support more ways to be invisible (XEP-0186, maybe XEP-0126, maybe whatever Google does)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=20768

--- Comment #12 from Will Thompson <will.thompson at collabora.co.uk> 2010-04-23 12:09:30 PDT ---
(In reply to comment #11)
> In both of those functions, you're sending the IQ to the server, and ignoring
> the reply. (_gabble_connection_send() only returns FALSE if we're not
> connected; any other errors are reported asynchronously.) Is that intentional?
> I feel like we should probably not silently ignore setting yourself as
> invisible failing asynchronously.
> 
> Also... we should probably listen for privacy list pushes to detect someone
> deleting our invisible list. (I'm not really sure what we should do if that
> happens... log a debug message? Try to re-create it?)

Okay, so there are a few failure cases:

• We can't even create the 'invisible' list in the first place. I think we
should wait and see if this operation succeeds before becoming connected, and
if it doesn't succeed, just don't offer invisible as a presence.
• 'invisible' exists, but setting it fails. This really shouldn't happen as
long as our IQ is correct (which isn't hard to ensure), so it failing means the
server is buggy or something else beyond our control. I think we should handle
this case by flipping our status back to Busy, so at least the user knows
they're not invisible.
• Someone else blows away our 'invisible' list and replaces it with something
else. I'm unsure how to deal here. An argument in favour of checking the list
at login — rather than just replacing it every time — is that we would prevent
this happening in the simple case of being connected with two Gabbles at once!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.