[Bug 26590] GetFrequentContacts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26590

--- Comment #5 from Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> 2010-04-28 06:44:22 PDT ---
Thinking of what FrequentContact does:

GetFrequentContact won't show the frequent ones, but the frequency for all
contacts that TPL knows about.

It means two things:

1) if what is wanted is a list of frequent contacts, would be good to add one
more parameter to the method: the number of contacts you want (n=10 would
return ten contacts, meaning the top-10 among the most frequent contacts).
if this is not the semantic for the methods, probably a rename of the method
would be a good idea, something like GetContactsFrequency.

2) the method returns all the contacts that TPL knows about, meaning all the
logged contacts. Among them there might be some that are actually not a contact
anymore for the user (ie removed contact or removed account).
It might be a good idea either to add a flag "show non-existing contacts" and
filter the result according to it, or document somewhere that the client need
to filter the list against non-existent contacts, if any.

The same for RecentContacts.

My two cents:

In a scenario with Folks, I like the idea to keep GetContactsFrequency-like API
in TPL and let Folks publish information per-individual instead of
per-identifier.
Raw information by TPL, refined by Folks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.