[Bug 25236] TpBaseClient - an abstract class to implement clients

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25236

--- Comment #34 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-04-28 06:45:28 PDT ---
(In reply to comment #32)
n everything up to "allow tp_base_client_register to
> fail". The changes up to and including "add base-client.h to telepathy-glib.h"
> look good, except for:
> 
> >   61  * Signature of the implementation of the ObserveChannels method.
> >   62  * This function MUST call tp_observe_channels_context_accept,
> >   63  * tp_observe_channels_context_delay or tp_observe_channels_context_fail.
> 
> This isn't an RFC (or telepathy-spec, which pretends to be one) so I'd be
> inclined to not capitalize MUST. How about this?
> 
>  * Signature of the implementation of the ObserveChannels method.
>  *
>  * This function must call either tp_observe_channels_context_accept,
>  * tp_observe_channels_context_delay or tp_observe_channels_context_fail
>  * on @context before it returns.

changed.

> > +/* FIXME: This function should be (skip) but that breaks gtk-doc <= 1.14 */
> 
> As of current master, we've decided to ignore that limitation and rely on
> having the necessary patch in gtk-doc (1.14-2 in Debian), so please (skip)
> this.

done.

> > +      DEBUG ("Failed to register bus name %s\n", string->str);
> 
> Remove \n

done.

> http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=commitdiff;h=8310b0e8bf0752604daae52c1cd8f50351a3752e
> > a
> 
> I assume this was meant to be squashed into "base-client: remove Approver and
> Handler code for now" :-)

Indeed :)
It is now.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.